Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 2.7.3 change list #4453

Merged
merged 5 commits into from
Jul 5, 2019
Merged

add 2.7.3 change list #4453

merged 5 commits into from
Jul 5, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

add change list

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4453 into 2.7.3-release will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.3-release    #4453      +/-   ##
===================================================
+ Coverage             63.4%   63.47%   +0.06%     
- Complexity             451      452       +1     
===================================================
  Files                  765      765              
  Lines                32696    32696              
  Branches              5151     5151              
===================================================
+ Hits                 20731    20753      +22     
+ Misses                9576     9556      -20     
+ Partials              2389     2387       -2
Impacted Files Coverage Δ Complexity Δ
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 20% <0%> (-1%)
...ache/dubbo/registry/multiple/MultipleRegistry.java 63.38% <0%> (+0.7%) 21% <0%> (+1%) ⬆️
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (+2.43%) 0% <0%> (ø) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 67.21% <0%> (+2.45%) 0% <0%> (ø) ⬇️
.../org/apache/dubbo/remoting/ExecutionException.java 21.05% <0%> (+5.26%) 0% <0%> (ø) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 78.94% <0%> (+5.26%) 0% <0%> (ø) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 57.14% <0%> (+5.71%) 0% <0%> (ø) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 71.42% <0%> (+9.52%) 0% <0%> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 53.94% <0%> (+10.52%) 17% <0%> (+1%) ⬆️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 56.81% <0%> (+11.36%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8baf929...e1cf38f. Read the comment docs.

ralf0131
ralf0131 previously requested changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the English version as well.

CHANGES.md Outdated
### 升级不兼容性声明

为了统一不同配置中心（如Zookeeper、Nacos、Etcd等）对于服务治理规则的实现，我们对2.7.0以来的配置中心的部分实现进行了重构。
**对于已使用了2.7.x新版本服务治理规则的用户，升级2.7.3之前请先[查看新版实现]()，了解[注意事项]()确保平滑升级。**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link?

@cvictory cvictory dismissed ralf0131’s stale review July 5, 2019 09:57

I have checked.

@cvictory cvictory merged commit a97d378 into apache:2.7.3-release Jul 5, 2019
@dubbo-bot dubbo-bot mentioned this pull request Jul 12, 2019
Closed
@chickenlj chickenlj deleted the 2.7.3-change-list branch September 3, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvictory cvictory cvictory approved these changes

@ralf0131 ralf0131 ralf0131 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chickenlj @codecov-io @cvictory @ralf0131